Added backward compatibility in the websocket branch #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ça marche pas encore tout à fait... j'arrive à avoir l'URL du devicehub mais pas du challengehub je comprends pas pourquoi. Si quelqu'un veut s'éssayer avec ça
J'arrive à la négociation du challengehub, chose qui ne se produisait pas avant, merci à @Leicas pour la suggestion. J'ai sorti le token du if pour y avoir accès dans la fonction au complet. Ça marche toujours pas, mais je pense que c'est un pas dans la bonne direction
Respect Black, remove unused imports
This reverts commit 465e2ff.
revenu à full_ws_url pour garder le même nom que le code original
Il y avait un string literal donc websocket ne se faisait pas remplir, websocket2 oui. Retrait et modification de quelques commentaires
Le post se fait maintenant dans websocket.py, dead code
Pour faire changement
Renommé pour être plus facile à suivre.
Clarifier un peu
Pour troubleshooting futur
Dans util, ajout de logique moins naïve sur le traitement des timezone, causait du trouble en websocket.
…ition to the new websocket for challenges without breaking the current HA Hilo code
ic-dev21
force-pushed
the
WebsocketManagerClass
branch
from
d148158 to
62d3536
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes add backward compatibility to the code, allowing a smooth transition to the new challenges websocket. The lib can be used by versions of Hilo for HA that are not yet updated to the newer websocket code.